feat: indexing for referencegrant #1618
Open
+440
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: siddharth1036 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1618 +/- ##
==========================================
- Coverage 83.26% 83.24% -0.03%
==========================================
Files 137 137
Lines 12059 12389 +330
==========================================
+ Hits 10041 10313 +272
- Misses 1411 1446 +35
- Partials 607 630 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: siddharth1036 <[email protected]>
dosubot
bot
added
the
size:L
mathetake
reviewed
Dec 5, 2025
internal/controller/controller.go
Outdated
| } | ||
|
|
||
| func getReferenceGrantIndexKey(namespace, kind string) string { | ||
| return fmt.Sprintf("%s/%s", namespace, kind) |
Member
There was a problem hiding this comment.
can you use the same format as others (name.namespace)
Signed-off-by: siddharth1036 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds indexing for referencegrants. The indexing key uses To Kind + namespace in referencegrant for indexing which would help fetch only related referencegrants given aiservicebackend and namespace.
Related Issues/PRs (if applicable)
Closes #1375